search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
255 stars 52 forks source link

Improve line number color matching to Atom editor #36

Closed jhacksworth closed 6 years ago

jhacksworth commented 6 years ago

Sorry about the inundation of pull requests. :grimacing: I didn't take Atom's opacity setting into account when updating the line number color in 81df7da. The opacity is not set in the same place as color, which is why I missed it. :anguished:

I made some screenshots for comparison. The shots are taken on a Mac:

Although we can match Atom's line number colors exactly (when adjusting for opacity in both line number and current line number) as seen in the following screenshot:

line number: #4b5363 current line number: #777c87 exact-to-atom

I think keeping atom-one-dark-fg for the current line number makes it easier to distinguish. This is what this pull request looks like:

line number: #4b5363 current line number: atom-one-dark-fg fg-for-current-line-number

And for reference, here is 81df7da:

line number: #636d83 current line number: atom-one-dark-fg master-51d197b

Talk about overthinking something! :smile:

jonathanchu commented 6 years ago

Wow, the level of careful detail and consideration that went into this is amazing. Thanks so much for paying so close attention to the details and for explaining so well! I'm excited to see this in action now! Cheers! :beers: