search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
256 stars 52 forks source link

Errors after MELPA update 20180116.1024 #38

Open ikosmidis opened 6 years ago

ikosmidis commented 6 years ago

Hi @jonathanchu

I am seeing multiple errors after I have updated to the latest version of atom-one-dark-theme from MELPA (20180116.1024)

Representative chunk from the errors are, but they occur whenever I change buffer

Unable to load color "#282C34" Invalid face reference: nil [75 times]

I do not see any issues with the colors used across environments (mu4e, org-mode, magit, ESS and others) but an annoying side-effect is that emacs has to re-draw all buffers after each switch, so I am disabling the theme for now.

I am on

GNU Emacs 25.3.3 (x86_64-apple-darwin13.4.0, Carbon Version 157 AppKit 1265.21) of 2017-09-28

Thanks -Ioannis

jhacksworth commented 6 years ago

Hey @ikosmidis, are you running GUI emacs or in the terminal?

What happens if you launch emacs with emacs -Q and then do:

(add-to-list 'custom-theme-load-path "/path/to/atom-one-dark") ;; change to your specific path
(load-theme 'atom-one-dark)

(about emacs -Q)

ikosmidis commented 6 years ago

I use the GUI on Mac OS X

I did open --new -a Emacs.app --args -Q

and pointed "/path/to/atom-one-dark" to both the directory installed from MELPA and to a fresh clone of the repo.

Behaviour is the same; buffer redrawing and Unable to load color "#282C34" in Messages.

I hope this helps.

Thanks, -I

jhacksworth commented 6 years ago

Thanks for your quick response @ikosmidis 😃

Unfortunately, I'm unable to reproduce this on my system. Can you tell me where your version of Emacs is from? In addition to the versions I have using homebrew, I also tried this version, but couldn't reproduce the error.

ikosmidis commented 6 years ago

I am using https://github.com/railwaycat/homebrew-emacsmacport, the pre-built version but same happens with the Homebrew one.

I also tried https://emacsformacosx.com and, as you, I cannot reproduce the issue with it.

What is weird is that the issue is there with railwaycat's build even with Emacs -Q.

Any ideas?

jhacksworth commented 6 years ago

Thanks for the link, @ikosmidis. The GUI looks really nice in the railwaycat version.

I tried the latest pre-built binary, which reports the same version string as the one you listed. I was still unable to reproduce the error 😕 Do you see the error as soon as the theme is loaded?

I'm on OS X 10.11.6 "El Capitan", for reference.

Any ideas?

One thing to try: change Line #60

from 

  `(let ((class '((class color) (min-colors 89)))

to 

  `(let ((class '((class color) (min-colors 0xFFFFFF)))

Does that have any effect?

ikosmidis commented 6 years ago

Thanks. I re-downloaded railwaycat version and the same happens on my side... (Yes, railwaycat is a cool distro for macOS), and your suggestion (thanks!) did not have much effect.

I am running on macOS 10.13.2 High Sierra. Perhaps this has something to do with it?

I'll also try and run a few more tests to see if I can find any peculiarities of my setup that cause this.

jhacksworth commented 6 years ago

I am running on macOS 10.13.2 High Sierra. Perhaps this has something to do with it?

Anyone else on macOS 10.13.2? Please try the railwaycat version and let us know. There are pre-built binaries so it only takes a few minutes to try. :bowtie:

Good luck with your tests, @ikosmidis. Thanks for trying out my suggestion. One idea would be to try using git-bisect to track down the bug.

In any case, thank you for reporting the issue!

jhacksworth commented 6 years ago

For reference, I installed High Sierra (10.13.3) and couldn't reproduce the issue.

ikosmidis commented 6 years ago

Thanks for checking. It must then be something specific to my machine then.

One last thing to try perhaps: the Unable to load color "#282C34" message pops up immediately when I do C-x 5 2. Does it appear to your installation?

Happy to deem this closed and specific to my setup if not. I will then try to borrow a friend's mac and re-open if I see it there.

Thanks again -I

jhacksworth commented 6 years ago

Using the railwaycat version, I tried C-x 5 2, which opened a new frame, but no errors.

Let me know if there's anything else you think I should try. Just to mix things up, I've also tried:

I'm not using a retina display, so that may be a difference between our systems.

Also:

I hope you're able to try it on a different mac, it would be good to have more test results.

Thanks for your help in tracking down this bug.

ikosmidis commented 6 years ago

Thanks for all these. I think I fixed that (at least temporarily).

I had the file ~/Library/Colors/Emacs.clr on all my mac machines, which is most probably left over from one of the past emacs version I ran on them.

I am not sure how this file affects things, but once I deleted that file the annoying side-effect that emacs had to re-draw all buffers after each switch stopped (recommendation came from http://permalink.gmane.org/gmane.emacs.macintosh.osx/6639)

I still get a few Unable to load color "#282C34" and Invalid face reference: nil messages but these are not disrupting my workflow.

I hope this is useful to other people, too.

-I

jhacksworth commented 6 years ago

That's great! 🎆 🎉

I'm really glad the theme is usable for you now. I wish we knew the cause for the warning messages, but at least it's not too disrupting.

Thanks for reporting your findings, I'm sure there are users who will find it helpful, even if they don't participate in the thread. 👍