search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
256 stars 52 forks source link

Color issues #40

Closed LeahArmstrong closed 6 years ago

LeahArmstrong commented 6 years ago

Seems like the #282C34 color isn't rendering properly. Haven't been able to figure out what might be the cause, but it's rendering as a vibrant blue tone:

screenshot 2018-02-08 17 20 10

Here's a shot of the hex colors rendering inline: screenshot 2018-02-08 17 25 09

Not getting any errors in the output either.

Emacs 25.3.1 Atom One Dark 0.4.0 Iterm2 Build 3.1.5

baco commented 6 years ago

Same issue here, running GNU Emacs 25.2.2 on Gnome-Terminal

jhacksworth commented 6 years ago

(This is a duplicate of #6)

This theme is designed for full, 24-bit, color. Emacs before version 26 can't do full color in the terminal. So, even if the terminal supports 24-bit color, as iTerm does, Emacs 25.x doesn't take advantage of it and many colors will not look right.

Note that a preview release of Emacs 26 is out and enables full color in the terminal. I'm using this theme with it on iTerm and tmux with no issues. 👍

But for now, if you're using Emacs 25.x and you want to use this theme in the terminal, you'll need to customize the colors that don't look right. You could try the suggestion here: https://github.com/jonathanchu/atom-one-dark-theme/issues/6#issuecomment-271777253