jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
256 stars 52 forks source link

Match vertical-border to Atom and improve mode-line colors #42

Closed jhacksworth closed 6 years ago

jhacksworth commented 6 years ago

Hi @jonathanchu,

This commit sets the vertical border color to match Atom and tweaks the color of inactive mode lines. Thanks to your foresight, we added Atom's border color as a variable, so it was a simple edit.

This is what Atom looks like with splits:

atom

Atom only has one mode line, but if we think of inactive mode lines in Emacs as the horizontal borders in Atom, we get this (what this commit looks like in GUI Emacs):

gui-new

This is what the Emacs theme looks like before this commit (current master):

gui-original

For reference, I'm attaching before and after shots of full color and 256 color terminals.

Emacs in full color terminal, before:

full-color-term-orig

Emacs in full color terminal, after this commit:

full-color-term-new

Emacs in 256 color terminal, before:

256color-term-orig

Emacs in 256 terminal, after this commit:

256color-term-new

I think this is a better match for the original Atom theme and a more logical approach.

What do you think?

jonathanchu commented 6 years ago

😍 I agree, this is a better match indeed and overall better! Thank you! :beers:

jhacksworth commented 6 years ago

Thanks , @jonathanchu! Cheers! 🍻

jonathanchu commented 6 years ago

@jhacksworth Hey! I added you as a collaborator, feel free to decline if you don't want it. 😛

jhacksworth commented 6 years ago

Wow! Thanks, @jonathanchu! :smiley: