Closed jhacksworth closed 6 years ago
😍 I agree, this is a better match indeed and overall better! Thank you! :beers:
Thanks , @jonathanchu! Cheers! 🍻
@jhacksworth Hey! I added you as a collaborator, feel free to decline if you don't want it. 😛
Wow! Thanks, @jonathanchu! :smiley:
Hi @jonathanchu,
This commit sets the vertical border color to match Atom and tweaks the color of inactive mode lines. Thanks to your foresight, we added Atom's border color as a variable, so it was a simple edit.
This is what Atom looks like with splits:
Atom only has one mode line, but if we think of inactive mode lines in Emacs as the horizontal borders in Atom, we get this (what this commit looks like in GUI Emacs):
This is what the Emacs theme looks like before this commit (current master):
For reference, I'm attaching before and after shots of full color and 256 color terminals.
Emacs in full color terminal, before:
Emacs in full color terminal, after this commit:
Emacs in 256 color terminal, before:
Emacs in 256 terminal, after this commit:
I think this is a better match for the original Atom theme and a more logical approach.
What do you think?