Unmatched braces are nigh invisible

[thomasheartman]

Unmatched parentheses, braces, and brackets in the editor turn black and are as good as invisible against the background. This makes it extremely hard to catch these errors and frequently leads to confusion when the syntax checker is complaining about unmatched braces. See the following screenshot for an example (there's a closing parenthesis immediately following the comma):

If this is due to the emacs rainbow parens and out of your hands, then I apologize, but if it's something that can be handled on your end, it'd be great to see a different coloration for unmatched parens, brackets, and braces.

[thomasheartman]

Pfft. Never mind. This is me not doing enough research on my own. It's the rainbow delimiters package, and I can customize it at will. Apologies.

[thomasheartman]

Woah, okay. Sorry for reopening this. On further inspection, it appears that unmatched braces are set to be black in atom-one-dark-theme.el, and while it can be customized, it strikes me as a strange default for the theme, and as such may warrant a reconsideration. I think I'll leave this issue open for now and await further comment. Thanks.

[jonathanchu]

Hey @t-hart! Thanks for reporting this and for the great detail to get me started. I'll take a closer look and see what's going on here. Cheers! 🍻

[elektronaut]

It's indeed set to black, the culprit is here:

`(rainbow-delimiters-unmatched-face ((t (:foreground ,atom-one-dark-black))))

I don't think the color choices for the various depths are great either. Cyan/blue, red-1/red-2 and orange-1/orange-2 are right next to each other and are hard to differentiate.

I can take a look at improving it.

[elektronaut]

Before:

After: