search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
255 stars 52 forks source link

Better support for terminal #6

Closed jonathanchu closed 6 years ago

jonathanchu commented 8 years ago

As reported by @feifanzhou:

screen shot 2015-10-31 at 12 02 17
feifanzhou commented 8 years ago

I'm running OS X El Cap, Emacs 24.5 (installed via Homebrew) running in iTerm 2.1. The issue happens even when I set my iTerm theme to Atom One.

howdoicomputer commented 8 years ago

Same.

ghost commented 8 years ago

agree with above

jvoisin commented 8 years ago

Same for Xubuntu. It would be great to force the background colour.

st3fan commented 8 years ago

Same for me. Is there a fix for this?

iporsut commented 8 years ago

From this http://stackoverflow.com/questions/63950/how-to-make-emacs-terminal-colors-the-same-as-emacs-gui-colors

I think because Terminal supports colors. We must create color pallate specific for terminal.

praveenperera commented 7 years ago

Any updates on this, same problem with iTerm

praveenperera commented 7 years ago

Found a solution you can add this code to change the background colours to one of the 256 colours only when running in non-windowed mode.

 ;; Customize background for terminal for atom one dark color
  (if (not window-system)
    (atom-one-dark-with-color-variables
      (custom-theme-set-faces
      'atom-one-dark
      `(default ((t (:background "gray14"))))
      `(linum ((t (:foreground "#262626" :background "#262626"))))
      `(hl-line ((t (:background "gray13"))))
      ))
    )
mdashx commented 7 years ago

Almost there for me... that blue highlighting in the helm buffer doesn't seem right.

screenshot 2017-01-10 at 9 40 46 pm

praveenperera commented 7 years ago

@mdashx try this in the user top of the user-init, instead of what I had above.

  (if (not window-system)
      (defvar atom-one-dark-colors-alist
        '(("atom-one-dark-accent"   . "#528BFF")
          ("atom-one-dark-fg"       . "#ABB2BF")
          ("atom-one-dark-bg"       . "gray14")
          ("atom-one-dark-bg-1"     . "gray13")
          ("atom-one-dark-bg-hl"    . "gray13")
          ("atom-one-dark-gutter"   . "#666D7A")
          ("atom-one-dark-accent"   . "#AEB9F5")
          ("atom-one-dark-mono-1"   . "#ABB2BF")
          ("atom-one-dark-mono-2"   . "#828997")
          ("atom-one-dark-mono-3"   . "#5C6370")
          ("atom-one-dark-cyan"     . "#56B6C2")
          ("atom-one-dark-blue"     . "#61AFEF")
          ("atom-one-dark-purple"   . "#C678DD")
          ("atom-one-dark-green"    . "#98C379")
          ("atom-one-dark-red-1"    . "#E06C75")
          ("atom-one-dark-red-2"    . "#BE5046")
          ("atom-one-dark-orange-1" . "#D19A66")
          ("atom-one-dark-orange-2" . "#E5C07B")
          ("atom-one-dark-gray"     . "#3E4451")
          ("atom-one-dark-silver"   . "#AAAAAA")
          ("atom-one-dark-black"    . "#0F1011"))
        "List of Atom One Dark colors.")
    )
mdashx commented 7 years ago

heck yea @praveenperera - it looks beautiful now! Thank you!

jakubdonovan commented 6 years ago

@praveenperera Whenever i paste it into the theme config file, it gives me an error while i load the theme. The error i get "end of file during parsing" any ideas?

jhacksworth commented 6 years ago

Can this be closed, now that f677222 is merged?

jonathanchu commented 6 years ago

@jhacksworth yes! And thank you again for all your great work into this 👍