search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
256 stars 52 forks source link

`slant` keyword messes up the colors. #61

Open sunhs opened 4 years ago

sunhs commented 4 years ago

Hey man, thanks for your great work.

I'm using GNU Emacs 27.0.50 (built from source) on Ubuntu 16.04.

For faces like font-lock-comment-face where :slant italic is set, the foreground and background colors are reversed. For example, if :foreground ,atom-one-dark-fg :background ,atom-one-dark-bg :slant italic is set, actually foreground will be atom-one-dark-bg and background will be atom-one-dark-fg.

From the doc, slant seems to trigger some terminal features.

I changed :slant italic to :slant ,(if (display-graphic-p) 'italic 'normal) and things work well in the terminal. Haven't tried it in GUI since I'm working via ssh.

Lack knowledge on this part and would be great if you could explain this.