search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
256 stars 52 forks source link

Ediff buffers have rather unreadable highlights #62

Closed ianyepan closed 3 years ago

ianyepan commented 4 years ago

Here are a couple of screenshots that showcases the highlights in ediff. They are sadly non-consistent with the atom-one-dark colourscheme, and appears to be rather unreadable.

Screenshot 2020-03-22 at 13 04 20 Screenshot 2020-03-22 at 13 04 34

My fixes

I have spent some time to experiment with the most opitmal colours, if I may kindly suggest:

  (ediff-fine-diff-A    ((t (:background "#885555"))))
  (ediff-fine-diff-B    ((t (:background "#558855"))))
  (ediff-fine-diff-C    ((t (:background "#555588"))))
  (ediff-current-diff-A ((t (:background "#663333"))))
  (ediff-current-diff-B ((t (:background "#336633"))))
  (ediff-current-diff-C ((t (:background "#333366"))))
  (ediff-even-diff-A    ((t (:background "#181a1f"))))
  (ediff-even-diff-B    ((t (:background "#181a1f"))))
  (ediff-even-diff-C    ((t (:background "#181a1f"))))
  (ediff-odd-diff-A     ((t (:background "#181a1f"))))
  (ediff-odd-diff-B     ((t (:background "#181a1f"))))
  (ediff-odd-diff-C     ((t (:background "#181a1f"))))

Here's how it looks like afterwards:

Screenshot 2020-03-22 at 13 25 06 Screenshot 2020-03-22 at 13 25 16
ianyepan commented 3 years ago

Friendly ping

jonathanchu commented 3 years ago

Hi @ianpan870102, I'm so sorry for the embarrassingly long delay in response here!

And sure, this is likely just an oversight that was missed! Feel free to make a PR, I'd gladly merge it in ASAP. If you're busy I can certainly add this in within the next day or two, but I'd want to give credit where it's due 😸

ianyepan commented 3 years ago

Hi @jonathanchu don't be! Glad you reached back 👍 I just created a PR with the colours I suggested above. Ready for your review.