search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
255 stars 52 forks source link

Line number merged with background and invisible in IPython running in vterm #65

Closed 0liu closed 3 years ago

0liu commented 3 years ago

First thank you for the awesome work bringing this great them to Emacs!

My setup: Ubuntu 20.10, Emacs 28 snapshot, Doom Emacs latest.

Issue: After turning on vterm in doom emacs init file and building the module, everything works. I launched IPython 7.16 in a vterm buffer. The line numbers of input and output are totally merged with the dark background and invisible. This is kind of inconvenient. Switching to doom-one theme line numbers are good.

Please see the screenshot attached.

atom-one-dark: atom-one-dark

doom-one: doom-one

jonathanchu commented 3 years ago

Hi @0liu! I'm very sorry about the delayed response here. I was able to replicate this in vterm and think I know what is missing. I'll create a patch for this and will let you know when this is fixed! I can see how this can be quite annoying not to see the line numbers as an ipython user myself 😅

jonathanchu commented 3 years ago

Hey @0liu I think I fixed this after some more debugging. Sorry for the messed up patch, my formatter is on the fritz I guess, but here is the conflicting code and it is in master now so should be published to MELPA shortly.

https://github.com/jonathanchu/atom-one-dark-theme/commit/b34b62e85593812b55ee552a1cb0eecfb04767bb#diff-546954d6616abc7a62f4ff7f1a06f459ad39d55e84be18aef68751ef1ca316e1L585-L593

Let me know if this resolves your issue! This was automatically closed out when I referenced the issue in the commit but will reopen for confirmation 😸

0liu commented 3 years ago

Great it works! Thank you for the great work.