jonathaneeckhout / jdungeon

An opensource 2d morpg game based on the Godot engine in a medieval inspired fantasy world
https://jdungeon.org
BSD 2-Clause "Simplified" License
130 stars 23 forks source link

Fix memory leak #229

Closed NancokPS2 closed 8 months ago

NancokPS2 commented 8 months ago

Changed Boost and SkillUseInfo to be RefCounted.

The Monitor was showing a steady increase in Objects in memory, not anymore. It's still kinda problematic that these many objects are being created, but it's likely an optimization issue (and the leak was probably always present, just ticking up too slowly to be noticed)

Reminder to self: Do not use "Object" for disposable stuff.

Closes: #228

jonathaneeckhout commented 8 months ago

Extended in:

https://github.com/jonathaneeckhout/jdungeon/pull/230

thanks for the input