jonathaneeckhout / jdungeon

An opensource 2d morpg game based on the Godot engine in a medieval inspired fantasy world
https://jdungeon.org
BSD 2-Clause "Simplified" License
131 stars 23 forks source link

Bug: Game menu softlocked on Report a bug navigation. #244

Open WithinAmnesia opened 8 months ago

WithinAmnesia commented 8 months ago

When entering the report a bug menu it does not return to the previous game menu and is stuck even after closing and reentering the game menus, it just needs a return button or something. Also the lag is over 1 second from input on player 1 screen and display of actions on player 2 screen; this is not ideal but good job on the online webport. I like the music in the title screen but maybe a volume slider would be nice. Also in lots of MMORPGs 1 account can make multiplayer characters so maybe add a character selection screen and character customization options there too. Also please add / enter new maps / dungeons / instanced content / player housing / banking / stash / auction house content to test. Also please how to access the previous non-webport build's abilities selection e.g. ranged combat? Thank you greatly for your time.

WithinAmnesia commented 7 months ago

https://github.com/jonathaneeckhout/jdungeon/issues/247#issuecomment-1939642645 Latency / lag is fixed with ~80-90 ms Currently Firefox and Chrome Browsers with hardware acceleration are about the same: Targets (~80-90ms) 10-99 ms - great 100-199 ms - excellent This is a really thomping success! Also 16 clients from one pc have been tested to work (barely, its a start). A R P G  V 000 003-9 (JDungeon_Online_Webport) Godot 4 NET  Technically 14+2_16 Clients Multiboxing Does Work!

jonathaneeckhout commented 7 months ago

Reducing the context of this issue to the bug mentioned about softlocking on the menu. Thx for testing and reporting.

Fox-Alpha commented 6 months ago

Hello,

i think i have found the reason.

Here: https://github.com/jonathaneeckhout/jdungeon/blob/d941345fd187e51d7d51d24027838baae3ba4b78/scenes/player/gamemenu/GameMenu.gd#L41

The input event catches the mouseclick in the submenu dialog and handle it as it was outside the GameMenu and close the gamemenu without freeing the active submenu