search

jonathangeiger / kohana-jelly

See the link below for the most up-to-date code
https://github.com/creatoro/jelly
MIT License
146 stars 34 forks source link

Beef up unittests #35

Open banks opened 14 years ago

banks commented 14 years ago

This will be ongoing but at this stage I feel we need to at least cover the basics as throughly as we can, as well as writing a test or adding a data set each time we fix a 'bug' to ensure we don't let it slip though again!

I'm happy to help out with this. I'd like us to be pretty confident that pretty much all of the API works as expected by the tim we get to 1.0.

jonathangeiger commented 14 years ago

Sounds good. How about you just pick an area that you feel needs more testing and start work on the tests. Post what you'll be working on here and I'll do the same, so there isn't any overlap in our work.

Since I fixed most of these bugs reported by raeldc, I'll start with going back and writing specific tests for the bugs as you suggest. There might be some overlap if you want to cover the more general relationships behavior, but that's okay.

banks commented 14 years ago

Great. I'll update here whenever I get time to write some more. Hopefully preventing too much overlap. I''l also try and write changes to the library in a more test-driven manner from now on.

jonathangeiger commented 14 years ago

I ported a few of the old ones over to 0.9.5. There weren't many changes needed, it was just that some of the old tests weren't very well thought out. If you see any you want to bring over, feel free to do so.

http://github.com/jonathangeiger/jelly-tests/tree/f545edc6db237eb0f3ca7a68ede0a2446c3f2ae4/tests/Jelly

Also, I've added a few tests for some of the issues that have come up, but alot of the issues raeldc reported regarding relationships should be in their own test suite instead of being handled by one little test.

jonathangeiger commented 14 years ago

Just added a few tests for testing that certain field types are properly saved and updated. Fixed quite a few little bugs in the process, so I'm happy.

leth commented 14 years ago

I've added some tests to my fork of the test suite to increase coverage of the field classes :)

See http://github.com/leth/jelly-tests/commit/8c45593c15fc36d8323ef1eb5b994dd8cda0e9ff