search

jonathangeiger / kohana-jelly

See the link below for the most up-to-date code
https://github.com/creatoro/jelly
MIT License
146 stars 34 forks source link

CodingStyle #7

Closed dewos closed 14 years ago

dewos commented 14 years ago

This's marginal, but would be nice if the core could follow more the official kohana styling conventions for comparison and parentheses.

http://dev.kohanaphp.com/wiki/kohana2/CodingStyle

if(!$foo) become if( ! $foo) if (($foo && $bar) || ($b && $c)) usually become if (($foo AND $bar) OR ($b AND $c))

glamorous commented 14 years ago

Is there a reason why some properties are placed between some methods?

jonathangeiger commented 14 years ago

Everyone asks about this and I don't really get why. The entire Kohana 3.0 source is structured this way:

  1. static properties
  2. static methods
  3. instance properties
  4. instance methods
glamorous commented 14 years ago

That makes sense... :)

dewos commented 14 years ago
dewos commented 14 years ago

I am closing this since it's fixed now.

jonathangeiger commented 14 years ago

Thanks. I was going to keep it open until I merged the unstable branch to master, but if you're happy now then I am too. :)