Support TYPO3 9 LTS - Githubissues

jonathanheilmann / ext-jh_magnificpopup

TYPO3 CMS Extension to integrate Magnific Popup

GNU General Public License v2.0

7 stars 13 forks source link

Support TYPO3 9 LTS #62

Open jonathanheilmann opened 6 years ago

jonathanheilmann commented 6 years ago

[x] Requires to drop TYPO3 7 LTS support
[x] Drop css_styled_content support
[x] Update ViewHelpers to use namespace TYPO3Fluid...
[x] Migrate from TYPO3_DB
[x] Mark eID as deprecated
[x] Use renderStatic() instead of render() in ViewHelpers
[x] Re-write plugin and introduce a compatibility mode to stay compatible to templates/partials from extension version 1.x
[x] Use jh-st-img to load images and added common css
[x] Update documentation

Tim-Obert commented 5 years ago

Any plans on releasing a new version compatible with 9 LTS? The tasks seem to be finished...

Regards

jonathanheilmann commented 5 years ago

There is an actual alpha https://github.com/jonathanheilmann/ext-jh_magnificpopup/releases/tag/2.0.0-alpha.2 but sadly not enough feedback for a final release.
It would be great if you could test the actual alpha and give some feedback about the used features and if there are any bugs. I do not expect any compatibility issues other than described here: https://github.com/jonathanheilmann/ext-jh_magnificpopup/blob/v2.0.0/Documentation/BreakingChanges/Version2000000/Index.rst

Tim-Obert commented 5 years ago

I tested the alpha and for me there are no problems but I only used the lightbox function for normal content

contechno commented 5 years ago

Hey Jonathan! I´ve tested the 2.0.0-alpha.2 Version with Typo3 9.5.8. Unfortunately, the Lightbox isn´t working. Additionally, I get the following error message when adding new content elements with images: Class 'JonathanHeilmann\JhMagnificpopup\Hooks\UpdateColPosHook' not found

jonnsn commented 5 years ago

@jonathanheilmann alpha 2 is working well for me too with 9.5.8. I used it with regular image content elements and also for images rendered by a custom Extension inside a slider.

@contechno : did you rebuild PHP Autoload Information in the install tool or composer dump-autoload?

contechno commented 5 years ago

@jonnsn I did it via the install tool. EDIT2: Now I figured out where the bug is: When normally adding an image-containing element, everything works fine. But when the image is added via the news-extension (tx_news) in a news-article, it doesn´t get the necessary class!

hweckhardt commented 5 years ago

I installed the extension as Plugin and tried to use it for displaying a video in the lightbox. I receive the following error message:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: Undeclared arguments passed to ViewHelper JonathanHeilmann\JhMagnificpopup\ViewHelpers\PageRenderer\AddJsInlineCodeViewHelper: name, addToFooter. Valid arguments are: | TYPO3Fluid\Fluid\Core\ViewHelper\Exception thrown in file /html/typo3/typo3_src-9.5.9/vendor/typo3fluid/fluid/src/Core/ViewHelper/AbstractViewHelper.php in line 476

I am using 9.5.9, bootstrap_package 11.0 and jh_magnicificpopup in the actual version on this github.