Hardware back button does not close the gallery photo viewer

jonathanheilmann / heilbaum-ionic-photoswipe

Ionic 2 module shipping the wonderfull PhotoSwipe JavaScript plugin

MIT License

10 stars 2 forks source link

Hardware back button does not close the gallery photo viewer #6

Open jjexperto opened 7 years ago

jjexperto commented 7 years ago

Hello, I installed your component and it is working great, but i have one problem, the hardware back button does not close the Photo viewer. Do you have the solution for this or did i missed one step in the installation guide. Greetings

jonathanheilmann commented 7 years ago

Hi, you didn't miss anything. If the hardware back button is not working, it's related to a missing implementation. I'm going to implement this in two weeks. If you can't wait for it you may try to do it on your own. It requires to add an event listener on ngInit and removing the listener on ngDestroy. A listener like this is required: https://stackoverflow.com/questions/18997793/javascript-backbutton-event-listener-overrides-the-android-device-back-button closing mfp on listener call

jonathanheilmann commented 7 years ago

Solving this issue isn't as easy as I thought. I'm still working on it.

jonathanheilmann commented 7 years ago

I've managed to create a solution. I'd appreciate if you could run

npm install heilbaum-ionic-photoswipe@beta

and leave some feedback if everything is working as expected or if not.

ASHFAQPATWARI commented 6 years ago

Is this issue resolved ?

niravparsana94 commented 4 years ago

Hi @jjexperto , Can you please tell how to use this photoswipe from scratch?