search

jonathanio / update-systemd-resolved

Helper script for OpenVPN to directly update the DNS settings of a link through systemd-resolved via DBus.
Other
761 stars 94 forks source link

Fix #62 #63

Closed Edu4rdSHL closed 5 years ago

jonathanio commented 5 years ago

@Edu4rdSHL Thanks for the pull-request. I'm going to merge this, although, once done I'm going to move the command until after the "${script_type}" ... call towards the end of the main() as that's what calls up() and down(), so it can be done in once place. Plus, by moving it until after that call, there is less chance of the race condition where possible DNS values are cached between the flushing of the caches and the full addition of the new DNS settings on the link.

Edu4rdSHL commented 5 years ago

Hello, @jonathanio you're totally right. Thanks for notify and do the re-work.

jonathanio commented 5 years ago

@Edu4rdSHL no problem. I in fact caught myself out having not run the tests with this refactor, but I've fixed the change and will release this (and a number of other changes) this afternoon.

Thanks again!

Edu4rdSHL commented 5 years ago

Very good, I was going to tell you about the release since that Im using the ArchLinux AUR package that use the versioned model.

Thank you for it excellent tool.

jonathanio commented 5 years ago

No problem. Once I've finished all the work on this I'll update the AUR package configuration and upload it there.