search

jonathanio / update-systemd-resolved

Helper script for OpenVPN to directly update the DNS settings of a link through systemd-resolved via DBus.
Other
761 stars 94 forks source link

Update update-systemd-resolved #65

Closed adq closed 5 years ago

adq commented 5 years ago

Supports openvpn servers which return multiple DNS domains.

I use this configuration at work to have a single DNS server (on the openvpn server itself), which should be used to lookup multiple different DNS domains when connected. This small change makes it work.

Tested with systemd 241.7 + openvpn 2.4.7

jonathanio commented 5 years ago

@adq I was initially going to reject this, but after looking into it again, I think, on the whole, this is a reasonable change. Unfortunately, this refactor has resulted in the failure of a number of unit tests. The issue is going to be how to handle the primary domain and I think this will need a few small changes.

I'm going to take your command and put it on a branch while I refactor some of the tests, which will allow me to manage these changes and properly handle multiple DOMAIN options cleanly.