search

jonathanklee / Sapio

Android Open Source API compatibility
GNU General Public License v3.0
108 stars 4 forks source link

Wrong device detection #13

Closed edern-appere closed 1 year ago

edern-appere commented 1 year ago

Hi there !

I'm running Sapio v 0.18 installed from F-droid. When I try to contribute, Sapio's detection of my current device configuration is incorrect and I cannot change it. I'm running LOS19.1+microg without root. Sapio detects my phone as microg+root !

How can I change this at my level, in order to make an accurate contribution ?

Thanks !

jonathanklee commented 1 year ago

@edern-appere Hey. Your device is detected as rooted. You can use this app to understand why your device is considered rooted: https://play.google.com/store/apps/details?id=com.scottyab.rootbeer.sample

theAkito commented 1 year ago

In my case, I get bareAOSP with root, but I have NikGApps installed. I hoped microG was only the most prominent example for Google Services supplements.

jonathanklee commented 1 year ago

@theAkito NikGApps is based on official Google Play Services no ? You're not supposed to contribute then.

theAkito commented 1 year ago

I see. Then the app must make sure people just trying to help won't contribute false results. I noticed, that the configuration was detected the wrong way. Perhaps others wouldn't notice & we would get wrong contributions.

Maybe it would help, if the app would generally check for what stuff they have & block their contribution with a warning like "your device has NikGApps installed, but we are looking for bare AOSP or microG based devices etc. etc. etc.".

Currently, I could've just proceeded and pretended, as if my phone were a bare AOSP device.

jonathanklee commented 1 year ago

@theAkito Thank you for your feedback. I'll implement some filtering.

jonathanklee commented 1 year ago

@theAkito This should have been implemented now. Thank you!