Corrected volume max setting not loading properly

owenfromcanada commented 6 months ago

Per discussion: https://github.com/jonathanklee/VolumeLockr/issues/3#issuecomment-2068413029

Summary by CodeRabbit

Release Notes

New Features
- Updated to support Android SDK version 34.
- Introduced dynamic theming with Material Design components.
- Added a new permission for media playback in foreground services.
Improvements
- Replaced SeekBar with Slider for a more modern user experience.
- Enhanced application theme to Theme.VolumeLockr for better visual consistency.
Bug Fixes
- Improved handling of volume settings and preferences.
Chores
- Updated build configurations and dependencies for improved performance.

BurnyBoi commented 6 months ago

Tested this PR: Stopping the service and starting the app again with "Allow lower than limit" enabled now stays functional as expected.

I did happen to notice if you set the volume lower than the limit while stopping the service and restarting the app, the upper limit gets changed to that lower volume, meaning you'd have to go into the app and turn it back up if wanted. This could be considered a feature rather than a bug though depending who you ask since it could help prevent getting hit with overly-loud volume in some cases.

coderabbitai[bot] commented 19 hours ago

Walkthrough

The changes in this pull request involve multiple updates across various files in the Android application. Key modifications include updates to the build.gradle file to reflect new SDK versions, application versioning, and dependency management. The AndroidManifest.xml has been adjusted for permissions and service configurations. A new method for loading preferences has been added in VolumeService.kt, while UI components have been replaced with Material Design counterparts in layout files. Additionally, a new application class has been introduced, and various theme updates have been made in the themes.xml files.

Changes

File Path	Change Summary
`app/build.gradle`	- `kapt` plugin applied as false - `compileSdkVersion` updated to 34 - `minSdkVersion` updated to 19 - `targetSdkVersion` updated to 34 - `versionCode` updated to 10 - `versionName` updated to "1.6.0" - `multiDexEnabled` set to true - `namespace` property added - Material library version updated to 1.12.0
`app/src/main/AndroidManifest.xml`	- `package` attribute removed - `android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK` added - `android:theme` updated to `@style/Theme.VolumeLockr` - `VolumeService` updated with `android:foregroundServiceType` and `android:exported` attributes
`app/src/main/java/com/klee/volumelockr/service/VolumeService.kt`	- New method `loadGeneralPreferences()` added - `onStartCommand()` modified to call `loadGeneralPreferences()` - `loadPreferences()` updated to include `loadGeneralPreferences()`
`app/src/main/java/com/klee/volumelockr/ui/MainActivity.kt`	- Import for `DynamicColors` added
`app/src/main/java/com/klee/volumelockr/ui/VolumeAdapter.kt`	- `SeekBar` replaced with `Slider` - `onBindViewHolder` updated for `Slider` - `registerSeekBarCallback` modified for `Slider` - Volume updating logic adjusted
`app/src/main/java/com/klee/volumelockr/ui/VolumeLockrApplication.kt`	- New class `VolumeLockrApplication` added, overriding `onCreate()` to apply dynamic colors
`app/src/main/res/layout/preference_switch.xml`	- New layout file defining a `MaterialSwitch` component
`app/src/main/res/layout/volume_card.xml`	- `CardView`, `TextView`, `SeekBar`, and `SwitchCompat` replaced with `MaterialCardView`, `MaterialTextView`, `Slider`, and `MaterialSwitch` respectively
`app/src/main/res/values-night/themes.xml`	- Style `Theme.Volume` removed
`app/src/main/res/values/themes.xml`	- New style `Theme.VolumeLockr` added - New styles `ThemeOverlay.App.Preference` and `PreferenceMaterialSwitch` added
`build.gradle`	- Kotlin version updated to `1.8.0` - Android Gradle plugin updated to `8.5.0`
`gradle.properties`	- New properties added: `android.defaults.buildfeatures.buildconfig`, `android.nonTransitiveRClass`, `android.nonFinalResIds`
`gradle/wrapper/gradle-wrapper.properties`	- `distributionUrl` updated to Gradle version 8.7

Poem

In the garden of code, we hop and play,
With sliders and colors, brightening the day.
From Volume to Lockr, our themes now align,
A switch here, a service there, all by design.
With every new feature, our app starts to bloom,
Hopping with joy, we chase away gloom! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

jonathanklee / VolumeLockr