jonathanlermitage / oga-maven-plugin

:jigsaw: Old GroupIds Alerter - A Maven plugin that checks for deprecated groupId+artifactId (e.g. did you know that graphql-spring-boot-starter moved from com.graphql-java to com.graphql-java-kickstart?).
https://central.sonatype.com/search?q=biz.lermitage.oga
MIT License
38 stars 7 forks source link

Fix #79 - Use plexus to support classpath resources #80

Closed pwhittlesea closed 3 months ago

pwhittlesea commented 3 months ago

Fixes #79

The code here is inspired by the PMD maven plugin https://github.com/apache/maven-pmd-plugin/blob/4afad98d229a6764d2ebdd246c037d1645c7cbb9/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L394

The aim is to support classpath configuration when using this plugin in parent aggregator projects where config is in a plugin dependency.

pwhittlesea commented 3 months ago

@jonathanlermitage The tests are passing locally for me but I'm not sure why they are failing here. Is there a way to pull the Maven log.txt files to see what happened?

pwhittlesea commented 3 months ago

@jonathanlermitage The tests are passing locally for me but I'm not sure why they are failing here. Is there a way to pull the Maven log.txt files to see what happened?

Figured it out 😄

jonathanlermitage commented 3 months ago

Thanks!
Will try to publish a new release next week.

jonathanlermitage commented 3 months ago

Hum, Maven makes some resistance, again 😅 I will try to publish the new 1.9.0 release asap. I used to deploy by running:

mvn clean release:prepare
mvn release:perform -P ossrh

(my ossrh maven profile is configured with my Sonatype creds, and my gpg passphrase)
but the second command fails saying

[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy (default-deploy) on project oga-maven-plugin: Deployment failed: repository element was not specified in the POM inside distributionManagement element or in -DaltDeploymentRepository=id::url parameter -> [Help 1]

It will simply take some time...

Nota: I received a Notice of Changes to OSSRH (Sonatype) Account Management. I will look at this.

Edit: okayyyy, I can't login to Nexus, and changing my password doesn't work... I will contact their support team.

pwhittlesea commented 3 months ago

Ooh that sounds rough @jonathanlermitage. I'm going to guess that because it's login related there is not much I can do to help, but if there is let me know!

Good luck!

jonathanlermitage commented 3 months ago

Thx! The Sonatype support helped me a lot. I just published the 1.9.2 release (strictly identical to 1.9.0) with success. It should be available in Central very soon. 🥳