Increase pattern rigor?

[mirh]

Removing whole folders only after a simple name check seems a bit too hazardous.

For example: some game may even legitly have some folder named "directx" (for reasons). A check for DXSetup inside these would really nullify chances of messing up.

And I guess the same is true for Physx and PhysX_systemsoftware.

I guess one could then point out "vcredit" is all but a "random" name.. Though I'd still find the "file whitelist" approach more elegant.

[jonathanlermitage]

Patterns check files/folders absolute paths ; you can improve the whitelist : https://github.com/jonathanlermitage/tikione-steam-cleaner/blob/master/dist2/conf/tikione-steam-cleaner_dangerous-items.ini

[mirh]

I honestly don't understand what should be the point of that list. Why should the program check in windows folder (or anything other than steamapps) in the first place?

... Even better, what about simply parsing folders mentioned inside the install vdf?

[jonathanlermitage]

Some users add "C:\" as a custom folder ;-)

About paths registered in vdf files: it was implemented in a previous version, then removed because it's not stable. I'll may accept Pull Requests about vdf parsing, but I won't re-implement it myself.

[mirh]

Some users add "C:\" as a custom folder ;-)

Oh... Right.. Never overestimate the user. Still, I don't see problems arising in a million of years, should you implement "strict" folder check. Aka "don't delete if there aren't [strictly only?] the files you'd expect that folder to contain".

then removed because it's not stable

How?

[jonathanlermitage]

patterns are now case-insensitive ; closing issue

[mirh]

patterns are now case-insensitive ; closing issue

That was another issue tbh. Here I was requesting a stricter rigor for deletion. Like checking for specific files inside matching folders, or now that I think, checking is files have any special sign or hash.