search

jonathanmccann / archive-url-firefox-addon

An addon for Firefox that allows on click saving to the Wayback Machine
https://addons.mozilla.org/en-US/firefox/addon/save-url-to-wayback-machine/
27 stars 5 forks source link

New version doesn't allow saving between archive.is and archive.org from the same button #10

Closed ajvsol closed 7 years ago

ajvsol commented 7 years ago

As title - I often save a URL to both so it would be a hassle to have to stick to the 'choose a default' type setting currently. Have downgraded to the previous version because of this.

jonathanmccann commented 7 years ago

The issue is that with the change to WebExtensions is that you can either have a toolbar button do an action or display a popup, unfortunately.

Do you save the same web page to both sites? If so, I could make it so that you could have the toolbar button save the page to both sites in two separate tabs. Let me know what you think and sorry about the regression.

ajvsol commented 7 years ago

So the popup cannot have the two links which each do different actions? I wouldn't mind if it was a full pop-up/new tab that asks this.

I usually save to both, less often just archive.is purposely. But if that's no longer possible then being able to choose both at the same time is a better option than just selecting one or the other.

Thanks for your quick response and I completely understand the limitations you have to deal with for the new extension framework.

jonathanmccann commented 7 years ago

I spent some more time on this and found a way around it. The behavior should be the same as the previous version.

There is a "One Click Save" checkbox in the preferences. If this is checked, then you are able to choose a default archiver and this archiver will be used when clicking the toolbar button and will be the only archiver shown in the context menu.

If it is unchecked, then the default archiver options are disabled. Clicking on the toolbar button will reveal a popup window that lets you choose either the Wayback Machine or archive.is. Additionally, both sites are shown in the context menu.

Please see https://github.com/jonathanmccann/archive-url-firefox-addon/commit/fc9d185d9c38e611578706acb880d6af57af0116 for the changes and let me know if the new version resolves the issue.

ajvsol commented 7 years ago

Works great, thanks!