search

jonathanmccann / archive-url-firefox-addon

An addon for Firefox that allows on click saving to the Wayback Machine
https://addons.mozilla.org/en-US/firefox/addon/save-url-to-wayback-machine/
27 stars 5 forks source link

option to edit url before sending #2

Closed atomGit closed 9 years ago

atomGit commented 9 years ago

seems like it might be a good idea to allow editing the url before it's archived, such as removing unnecessary params???

jonathanmccann commented 9 years ago

Thanks again for the feature requests. Please see af4904303b1b4059253832ff6720bee35d5e3c6c for adding a text box with the current URL that the user can modify. Also see cdda0db77e7215d9ae999cb624433ac5b4137150 which lets the user use the 'enter' key to save the modified URL to the default archiver. Let me know what you think about the implementation and if you think it'd work better a different way.

atomGit commented 9 years ago

hi jonathan for the tool-bar button, i think the text input control could be bigger... http://s6.postimg.org/spxhm8wf5/screenshot_191.png

i haven't figured out how to edit the url from the context menu link however - is this possible? if not, that's fine with me

jonathanmccann commented 9 years ago

Strange, the textbox for me fills the entire pop-up panel. I'll take a look at it again.

Editing the URL from the context menu is not possible at the moment. I wanted to keep this as simple as possible, so I restricted altering the URL to the toolbar.

atomGit commented 9 years ago

the better and simpler way to do this might be to re-read the address bar at upload time - that way one can just edit the url in the address bar and you don't have to add a UI to do it ???

jonathanmccann commented 9 years ago

I really like that idea! It keeps everything simple, but still gives users the freedom to change the URL. I went ahead and opened https://github.com/jonathanmccann/wayback-machine-firefox-addon/issues/4 thanks!

atomGit commented 9 years ago

sorry to cause you extra work - that was on my mind when i first suggested the feature :)