search

jonathanmccann / archive-url-firefox-addon

An addon for Firefox that allows on click saving to the Wayback Machine
https://addons.mozilla.org/en-US/firefox/addon/save-url-to-wayback-machine/
27 stars 5 forks source link

[cosmetic] context menu should reflect archive option #5

Closed atomGit closed 8 years ago

atomGit commented 9 years ago

if the default is set to archive.is, the context menu should probably reflect this

jonathanmccann commented 9 years ago

Hey, what version are you on? With 0.0.4, this is working properly for me.

archiveiscontextmenu

atomGit commented 9 years ago

ah! it IS working, but i had to toggle back to archive.org and then archive.is again before the menu text changed

jonathanmccann commented 9 years ago

Very strange. I'll leave this issue open and see if I can reproduce that behavior. Thanks for reporting it!

atomGit commented 9 years ago

try uninstalling and deleting any leftover prefs, then install and switch to archive.is and check the context menu

atomGit commented 8 years ago

hi jonathan

this is still an issue for me - don't know what's causing it, but the context menu label does not reflect the archive site name when it is set to archive.is after a while (it works at first, then changes)

the proper site is opened (archive.is), but the menu item says 'save to wayback machine'

jonathanmccann commented 8 years ago

I believe the issue is that when the extension starts, it doesn't read the value from the preferences, rather it is hardcoded so that it would not be null. This was a misunderstanding of preferences on my part and it should read from the preferences from the beginning. I'll try to get this fixed and submitted soon.

jonathanmccann commented 8 years ago

Please see https://github.com/jonathanmccann/wayback-machine-firefox-addon/commit/c488e5298f90f3bfd5839ff663a546aed3253f6d

This will be included in version 0.0.5. I believe I have fixed the issue. The steps I took to reproduce were:

  1. Install extension
  2. Change the default archiver from Wayback Machine to archive.is
  3. Install the extension on top of the previous installation
  4. Assert context menu label is Wayback Machine and not archive.is

Let me know if you still encounter the issue though.