search

jonathanmorley / asdf-bundler

Apache License 2.0
7 stars 4 forks source link

[#3] Fix shim script to launch correct version #4

Closed raxod502 closed 2 years ago

raxod502 commented 3 years ago

Before:

% ASDF_BUNDLER_VERSION=1.17.3 asdf exec bundle version
Bundler version 2.1.2 (2021-05-12 commit unknown)
% ASDF_BUNDLER_VERSION=2.2.24 asdf exec bundle version
Bundler version 2.1.2 (2021-05-12 commit unknown)

After:

% ASDF_BUNDLER_VERSION=1.17.3 asdf exec bundle version
Bundler version 1.17.3 (2018-12-27 commit d7089abb6)
% ASDF_BUNDLER_VERSION=2.2.24 asdf exec bundle version
Bundler version 2.2.24 (2021-07-15 commit d78b1ee235)
jonathanmorley commented 3 years ago

Can we add some regression tests? (even just the examples you listed above)

raxod502 commented 3 years ago

Do you happen to know why the existing test suite didn't find this issue already? I see that you are using asdf-vm/actions/plugin-test, but perhaps it just runs the command and does not check that the version is correct?

dvicory commented 2 years ago

I'm having this issue as well - the default bundler with ruby ends up getting used. Using this branch fixes it. What would it take to move forward on this?

raxod502 commented 2 years ago

Ah, CI is not passing yet! https://github.com/asdf-vm/asdf/pull/1078 needs to be merged upstream :)