Safety improvements - Githubissues

jonathanong / heroku-buildpack-ffmpeg-latest

A Heroku buildpack for ffmpeg that always downloads the latest static build

MIT License

360 stars 720 forks source link

Safety improvements #40

Closed ridem closed 3 years ago

ridem commented 3 years ago

Buildpack will fail less often, and when it does it will exit accordingly.

A few changes that make it safer to use:

Download is retried on failures. We check against the status code
Ability to set a custom URL through the FFMPEG_DOWNLOAD_URL config var
Downloads and unpacks from the filesystem

Fixes #27 , Fixes #32

jonathanong commented 3 years ago

I've added both @ridem and @artoonie as collaborators. please CR each other's PRs :)

ridem commented 3 years ago

@artoonie Awesome, thanks!

NB: Not touching the test workflow for now, but they were passing even though ffmpeg download was failing. We should have a better idea about how often it fails from now on.

See https://github.com/jonathanong/heroku-buildpack-ffmpeg-latest/runs/2886283251?check_suite_focus=true from 6mn ago

kriss897 commented 1 year ago