search

jonathanpeppers / inclusive-code-reviews-browser

A chrome web extension for improving code reviews on Github or Azure DevOps
GNU Lesser General Public License v2.1
32 stars 15 forks source link

Support for reviews in github.dev #115

Open elinor-fung opened 2 years ago

elinor-fung commented 2 years ago

I use github.dev for the vast majority of PRs I review. The extension doesn't seem to trigger in that web-based editor (maybe the comment box is not a textarea?). Support for that view would allow the extension to be part of my usual PR workflow.

jonathanpeppers commented 2 years ago

@elinor-fung can you share a screenshot of what that looks like? 😄

Would the proper solution be for us to implement something that runs inside VS Code? Gives suggestions on pull requests you are reviewing inside VS Code?

elinor-fung commented 2 years ago

Using the open PR in this repo as an example: https://github.dev/jonathanpeppers/inclusive-code-comments/pull/90/files

This is a comment box where I would have expected the status glyph / something from the extension: image

jonathanpeppers commented 2 years ago

It appears to work in this one:

image

But yeah it doesn't seem to work on this box for some reason:

image