jonathanpeppers / inclusive-code-reviews-browser

A chrome web extension for improving code reviews on Github or Azure DevOps
GNU Lesser General Public License v2.1
32 stars 14 forks source link

Explore handling of words in various forms #32

Open rachelkang opened 2 years ago

rachelkang commented 2 years ago

What will we do when a word...

rachelkang commented 2 years ago

at the very least, maybe we can have it ignore spaces? so it can underline the base of a word that may have any of these suffixes?

jonathanpeppers commented 2 years ago

It used to ignore spaces, but then I saw it underline "hang" in the word "changes":

https://github.com/jonathanpeppers/inclusive-code-comments/issues/16

For plurals, maybe it makes sense to just put another entry in the dictionary? I think about the word "masters", someone probably isn't talking about branches, so "mains" wouldn't make sense but "primaries" does.

I also think "mastering" is probably an OK usage? "I am mastering this technique." Let me know what you think.

I think we should aim to give suggestions for the common cases, and we can keep improving things as we go.