search

jonathanperret / paysage

Paysage is a visual shared playground for code.
http://paysage.xyz
GNU Affero General Public License v3.0
20 stars 9 forks source link

Rename a creature #110

Closed etienneCharignon closed 6 years ago

etienneCharignon commented 6 years ago

In order to avoid renaming the id of code object, I introduced "name" property on CodeObject.

This name is not sent to the renderer. The renderer is not impacted by this PR.

Programmers' view know contains two input fields, name and id. Id is hidden.

jonathanperret commented 6 years ago

I just pushed a proof of concept of removing the code rename event and its supporting methods.

etienneCharignon commented 6 years ago

removing the code rename introduced a weird behaviour when you rename a creature that you never submited (never gone live). This creates a creature with that name, but without any code. If you click on the creature in the list… it delete your code. 😅

etienneCharignon commented 6 years ago

@jonathanperret, I would like to merge this PR before Monday 9th July, for the RMLL. Do you see anything left to do ?

On my side, I like it as it is.

jonathanperret commented 6 years ago

So now, a creature's name is blank unless entered by the user, apparently. If I try to use Paysage as I'm used to, here's the result:

image

The whole point of random creature names was to lower the barrier to entry: it should be very easy to add a creature, without having to think of a name… :cry:

etienneCharignon commented 6 years ago

Yes, I did that on purpose as an experiment for the RMLL conference. This does not have to stay like this.