Replace simple textarea by code editor

jonathanperret / paysage

Paysage is a visual shared playground for code.

http://paysage.xyz

GNU Affero General Public License v3.0

19 stars 9 forks source link

Replace simple textarea by code editor #42

Closed lisa-durand closed 7 years ago

lisa-durand commented 7 years ago

We used codemirror to include JavaScript syntax highlighting and line numbers. PTAL :) :) <3 <3 #endOfDay

jonathanperret commented 7 years ago

Thanks for this PR! A better editor will surely improve the Paysage experience.

I don't see a dependency on codemirror being declared in bower.json though, and indeed when I run your code I get a 404 on codemirror.js and associated files. Could you please fix this?

jonathanperret commented 7 years ago

I just tested the result, looks awesome! ❤️

I just commented about the initialization code, if you can tighten it a bit I'll be delighted to merge this. Here's a rabbit: 🐇

lisa-durand commented 7 years ago

Glad you like it! Here's a magic hat 🎩

etienneCharignon commented 7 years ago

Attention, apparently the code is not reloaded when you click on the name of a creature in the liste of creature in the developper view.

etienneCharignon commented 7 years ago

after some more testing, it appears that there is the two following layout problems

on firefox : the scrolling does not work
on chrome and firefox (at least) : when entering a very long line (without space) the preview pane disappear.

jonathanperret commented 7 years ago

Merging, thanks! 🌈🦄