search

jonathanperret / paysage

Paysage is a visual shared playground for code.
http://paysage.xyz
GNU Affero General Public License v3.0
19 stars 9 forks source link

Fix the serpent white glitch when it turns #67

Closed etienneCharignon closed 7 years ago

etienneCharignon commented 7 years ago

set the fill of the vertex to transparent to avoid the white glitch. Also change the color to give an example of how to do it

juliendorra commented 7 years ago

We could use this branch to make a better suited Serpent example: easier to read, easier to hack for fun, easier to extend.

etienneCharignon commented 7 years ago

I like to keep the fill function close to the curveVertex() to give a clue to the developer about it's role in this code.

What do you think ?

jonathanperret commented 7 years ago

I love the idea of improving the examples, they do need it!

This PR is already a nice improvement as it stands, but I agree that there's a lot more code that can be removed from this example, which started out as a customizable creature and retains vestiges of this complicated past. I'm not even sure it needs a class, for a start.

The language (French vs English) is a tricky question. Will we need a localization system at some point?

@etienneCharignon are you willing to go further in the simplification of this example in this PR? If not, I'll merge what we have now and we can come back to it later, just let me know.

etienneCharignon commented 7 years ago

I've done this new simplification (I love coding in the morning when kids sleep). I won't do more.

jonathanperret commented 7 years ago

Thanks for the improvements! 💟