jonathanperret / paysage

Paysage is a visual shared playground for code.
http://paysage.xyz
GNU Affero General Public License v3.0
20 stars 9 forks source link

Improve code examples #98

Closed etienneCharignon closed 6 years ago

etienneCharignon commented 6 years ago

The new error detection mecanisme seams to have revealed error in examples.

jonathanperret commented 6 years ago

❤️ this. Keep going!😘

etienneCharignon commented 6 years ago

I'd be pleased to keep going on this improvement but could we merge this rapidly to fix the fact that, today, the creature example is not working ?

jonathanperret commented 6 years ago

It doesn’t? 😮 I wasn’t expecting the new error reporting to impact behavior but thinking about it, there is something new: we stop execution at the first error. I guess that’s what happens here.

jonathanperret commented 6 years ago

Looking into it a bit more, I realized the exact problem was that when I worked on the error-handling code, I changed the way the compiled code was evaluated. Long story short, it is now evaluated in strict mode whereas that wasn't the case before. I know how to go back to non-strict mode (keeping the error-handling features working, of course) but if everything works in strict mode I'd rather leave it as-is.