search

jonathanraftery / bullhorn-auth-client

Simple client to create Bullhorn REST API sessions with automated OAuth2 login.
1 stars 5 forks source link

Change URL constant references from self to static #3

Closed KajdeMunter closed 4 years ago

KajdeMunter commented 4 years ago

This makes it possible to override the URLs for development purposes. In my use case I have a mock API that uses a different URL.

Overriding constants is not very pretty. A cleaner solution would be to follow SOLID more strictly, mainly the Open/closed and Dependency inversion principles. But as I have limited time this will do fine for me.

Thanks for the package!