search

jonathanrdelgado / SublimeTodoReview

A SublimeText plugin for reviewing todo (and other) comments within your code.
MIT License
338 stars 46 forks source link

Crash when calling TodoReview while it's tab is already open #131

Closed Code-Curious closed 9 years ago

Code-Curious commented 9 years ago

Hi,

Whenever I run one of the TodoReview commands and the TodoReview tab is already open (I ran the command before), instead of switching to that tab or refreshing it, Sublime text (and my whole computer) freezes for a minute until plugin_host crashes.

I am using ST3 on Windows by the way

diego1araujo commented 9 years ago

+1 yep. can confirm

jonathanrdelgado commented 9 years ago

Can I get your full OS and Sublime Build versions?

I can't reproduce on Windows 10, latest ST3 Build.

diego1araujo commented 9 years ago

Just to clarify.. I see a similar issue but my pc does not freeze. (Windows 7 ST3 Build 3083).

The problem I've noticed is when TodoReview tab is already open and I run the command to execute again, It doesn't switch to TodoReview tab and I see a blank page as well.

todoreview

jonathanrdelgado commented 9 years ago

Has this functionality ever worked for you @diego1araujo?

Code-Curious commented 9 years ago

I am using ST build 3083 on Windows 8

marekkaczkowski commented 9 years ago

+1 same here ;(

jonathanrdelgado commented 9 years ago

Fixed by #133 and 5105f7133883f3522c1b417fd231d49adae0de06

Thanks for the report.

Code-Curious commented 9 years ago

You are welcome, unfortunatly, I am sorry to say that v3.0.7 has not fixed this issue, I still get the huge freeze when running TodoReview while its tab is still open.

FichteFoll commented 8 years ago

Still experiencing similar issue:

Traceback (most recent call last):
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 550, in run_
    return self.run(edit, **args)
  File "C:\Users\Fichte\AppData\Roaming\Sublime Text 3\Packages\TodoReview\TodoReview.py", line 233, in run
    self.draw_header()
  File "C:\Users\Fichte\AppData\Roaming\Sublime Text 3\Packages\TodoReview\TodoReview.py", line 292, in draw_header
    date = datetime.datetime.now().strftime(datestr)
TypeError: strftime() argument 1 must be str, not None

Only occurs when the TodoReviw view is open already. Trying again works.

jonathanrdelgado commented 8 years ago

@FichteFoll Just fixed that in 636914b for you, seems like it was the same issue as #133, i'm not sure why the sublime settings objects stop working out of the blue.

FichteFoll commented 8 years ago

Thanks for the hotfix. I looked into the code briefly but couldn't spot an obvious flaw during that time, which would make this hotfix necessary.

The fact that it is so reliably reproducable and I haven't had any problems with settings objects recently whatsoever leads to the thought it might be an error in TodoReview's code, however.