search

jonathanrobichaud4 / ha-nanoleaf-4D

Modified HA Nanoleaf integration that adds basic support for the Nanoleaf 4D
6 stars 0 forks source link

not working: effect selection and activation #1

Open jonathanrobichaud4 opened 8 months ago

jonathanrobichaud4 commented 8 months ago

OP: @KC-inDomus Issue originally posted here.

tested. 1D-2D-3D-4D effects are on the effects list. not working: effect selection and activation (the new ones as the standard ones).

KC-inDomus commented 8 months ago

now it works fine. don't know why. tried restarting the whole chain, now everything (I mean everything) works.

jonathanrobichaud4 commented 8 months ago

@KC-inDomus that is very weird! Keep me updated if anything else goes wrong. It's been working well for me but I'm not sure if it's affected home assistant by like slowing it down or causing more errors as it seems like I have more errors in my logs but they're all unrelated to the integration

KC-inDomus commented 8 months ago

still working fine. just a question: thinking about asking to merge this changes you made to the official nanoleaf integration?

jonathanrobichaud4 commented 8 months ago

Currently I have a PR in the upstream aionanoleaf package but I think someone mentioned it isn't maintained anymore. I also don't really want to replace the package in the main homeassistant integration if we're not sure it will cause issues with a homeassistant instance. For now I'd say test for a bit and then we'll see in a month? I also am unsure if my/nanoleaf's methods of getting the 4d modes from the device are up to HA's quality standards as it is a bit janky.

KC-inDomus commented 8 months ago

Pick one: or the main aionanoleaf gets your (goodi, imho) PR, or you can hypothesize to release an autonomous custom component (alternative to the actual official integration) ;)

jonathanrobichaud4 commented 7 months ago

Pick one: or the main aionanoleaf gets your (goodi, imho) PR, or you can hypothesize to release an autonomous custom component (alternative to the actual official integration) ;)

Hey, sorry for not replying earlier!! I have been busy with school and finals season. I'm just going to keep this as a custom integration for now since it makes maintenance easier for me! If someone else came along and wanted to merge the code I'm perfectly ok with that though! However I don't think it would get merged into home assistant until events are added to the API.