Contribute MPLEditor to official traitsui

jonathanrocher / ets_tutorial

Enthought Tool Suite tutorial

5 stars 7 forks source link

Contribute MPLEditor to official traitsui #36

Open jonathanrocher opened 2 years ago

siddhantwahal commented 2 years ago

@corranwebster A couple of questions for you:

Where would be an appropriate place for this editor? The DataFrameEditor is another editor with an optional dependency, but one that's fully baked into TraitsUI. Should we follow a similar approach?
Do we have to bring in the wx implementation of MplFigureEditor into TraitsUI at the same time as the Qt one?
Is an example or a demo also needed in TraitsUI at this stage?

corranwebster commented 2 years ago

Answers:

it should probably go in traitsui.editors and traitsui.qt4, but perhaps not be in any api modules just yet. Also some care might be given for a good error message if matplotlib is not available if someone tries to use it
no, you can implement Qt and Wx will automatically get a dummy "unimplemented" version which errors if it actually gets used.
documentation is more important, but a demo would be nice as it allows people to manually test things.

prabhuramachandran commented 1 year ago

Hi @siddhantwahal and @corranwebster -- was this ever added to traitsui? I think this would be super useful to have. Could this please be added to a future release? Thanks.