search

jonathanrocher / ets_tutorial

Enthought Tool Suite tutorial
5 stars 7 forks source link

Convert stage 3 into a single file #44

Closed siddhantwahal closed 2 years ago

siddhantwahal commented 2 years ago

This PR converts stage 3 into a single file.

In stage 2 (#42), we're adding a traits-equipped version of the script with an ImageFile model. In this PR, we extend that simple script with a traitsui view for ImageFile, ImageFileView.

Model and views for ImageFolder have been removed. Thus, the ImageFolder will be introduced for the first time in Stage 5.1.

siddhantwahal commented 2 years ago

@jonathanrocher I've split this into two stages, 3.0 and 3.1. Let me know if it's headed in the right direction!

siddhantwahal commented 2 years ago

I like this, my only request is that the plotting code also be rolled into a method on the model initially, but if you and @jonathanrocher feel strongly that it should not be there, this is fine as at least the code is in an if __name__... block.

Thanks for the review @prabhuramachandran! I'm merging this for now, but happy to come back and add a plotting method if that's what we decide in #42.

siddhantwahal commented 2 years ago

Actually, @jonathanrocher, did you want to take another look?