search

jonathanslenders / asyncio-redis

Redis client for Python asyncio (PEP 3156)
http://asyncio-redis.readthedocs.org/
Other
552 stars 73 forks source link

Function `asyncio_redis.Connection.create()` hangs if connection can't be established #128

Open vikt0rs opened 5 years ago

vikt0rs commented 5 years ago

If someone tries to create a connection to the wrong host (for example) function asyncio_redis.Connection.create() hangs forever and the user gets no error message.

From my side, it happens in _reconnect() method [0] because of the while True: loop - it has no exit condition on connection error and it retries connection attempts forever

[0] - https://github.com/jonathanslenders/asyncio-redis/blob/master/asyncio_redis/connection.py#L93

vikt0rs commented 5 years ago

Pull request https://github.com/jonathanslenders/asyncio-redis/pull/118 looks like a solution for this issue. @jonathanslenders - any hope that the PR will be merged someday?

mateuszmandera commented 4 years ago

Can this be closed, considering https://github.com/jonathanslenders/asyncio-redis/commit/f2ae63533491f311130dfb43e347814cb7055140 was merged?