search

jonathanstowe / TermReadKey

Character mode terminal access for Perl
12 stars 27 forks source link

refactor ReadKey.pm #18

Closed rurban closed 7 years ago

rurban commented 7 years ago

auto-generate the platform-specific parts at installation. expand blockoptions specific variants already at installation, demand-load Carp, remove unneeded AutoLoader, harmonize formatting.

Configure.pm, genchars.pl: reformatting, support -Dfortify_inc and cperl.

Makefile.PL: support ReadKey_pm.PL, add SIGN, fix pure_site_install, fix realclean

META.yml: removed, auto-generated with make dist

jonathanstowe commented 7 years ago

Hi, thanks for this, it looks good but would it be possible to split this into two commits, one with the formatting changes and the other implementing the generation of the ReadKey.pm? This will make it easier to revert if there is a problem down the line.

Thanks again.

rurban commented 7 years ago

sure, will push force to this branch.

note that there already is a problem down the line on darwin only already, only on my travis smoker with a fixed/changed Socket library, and the old Term::ReadKey 2.34. That's why I started looking at it at all. https://travis-ci.org/perl11/cperl/builds

jonathanstowe commented 7 years ago

Cool, thanks :)

The problems I foresee are with upstream packagers. I'm going to make a 'dev' _RC1 release with this to get a flavour of how much they will scream before making a proper release.

Thanks again.

rurban commented 7 years ago

Shouldn't I seperate the reformatting of the eval code sections in the .pm also? There was also a lot of reformatting going on.

rurban commented 7 years ago

Ah, too late. I was in the movies :) Thanks!