search

jonathanstowe / TermReadKey

Character mode terminal access for Perl
12 stars 27 forks source link

Fix some warnings #2

Closed jacquesg closed 10 years ago

jacquesg commented 10 years ago 
ReadKey.xs:1400:3: warning: expression result unused; should this cast be to 'void'? [-Wunused-value]
                (void*)hv_delete(filehash,(char*)&handle,sizeof(int),0);
                ^    ~
ReadKey.xs:1401:3: warning: expression result unused; should this cast be to 'void'? [-Wunused-value]
                (void*)hv_delete(modehash,(char*)&handle,sizeof(int),0);
                ^    ~
jonathanstowe commented 10 years ago

Looks good to me, don't know why I've never seen the warning :)

Thanks

jacquesg commented 10 years ago

These warnings come from the the gcc (clang) compiler on OS X. Its pedantic...

jonathanstowe commented 10 years ago

On Sat, 2014-05-10 at 04:44 -0700, Jacques Germishuys wrote:

These warnings come from the the gcc (clang) compiler on OS X. Its pedantic...

Glad to know that it even builds there, I've only tested on Linux and FreeBSD over the last couple of years :)

Anyhow I just released 2.32 to the CPAN because the number of changes seemed enough.

Thanks for the patch.