search

jonathantneal / flexibility

A JavaScript polyfill for Flexbox
https://jonathantneal.github.io/flexibility/
MIT License
4.33k stars 479 forks source link

Make normalize function more resilient. #76

Closed anthony-dandrea closed 6 years ago

anthony-dandrea commented 8 years ago

Probably not worth merging, but I thought I would share my findings.

In reference to https://github.com/jonathantneal/flexibility/issues/34, https://github.com/jonathantneal/flexibility/issues/23, & https://github.com/jonathantneal/flexibility/issues/61.

Basically the library was calculating whack styles on ie8 for some reason where the values would be something like "auto-5" or "0auto-255". Then when piped through the normalize function in index.js just "px" would be appended to the end. Then when trying to set a style of "0auto-255px" for anything it would barf. Now I'm checking to see if we're dealing with an actual number, if not then I just give it "0px".

sunnykgupta commented 8 years ago

Is this being considered?