jonathantneal / flexibility

A JavaScript polyfill for Flexbox
https://jonathantneal.github.io/flexibility/
MIT License
4.33k stars 479 forks source link

Tests not running #88

Open emeaguiar opened 7 years ago

emeaguiar commented 7 years ago

While trying to run tests npm run test the command fails since "10up" is not an preset that exists, besides, jscs has been deprecated in favor of eslint.

I'll update removing jscs and adding the correct eslint configurations.

mreinstein commented 6 years ago

@emeaguiar do you have the eslint configs? I'm happy to get this fixed/merged.

jonathantneal commented 6 years ago

Swapping 10up for dev resolves the issue.

mreinstein commented 6 years ago

@jonathantneal I'm not able to replicate this. updating this part of package.json:

"jscsConfig": {
    "preset": "dev"
  },

I still get an error:

🤡 npm test

> flexibility@2.0.1 test /Users/mikereinstein/Sites/flexibility
> npm run jscs

> flexibility@2.0.1 jscs /Users/mikereinstein/Sites/flexibility
> jscs ./lib/

Preset "dev" does not exist
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! flexibility@2.0.1 jscs: `jscs ./lib/`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the flexibility@2.0.1 jscs script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mikereinstein/.npm/_logs/2018-08-01T15_59_07_636Z-debug.log
npm ERR! Test failed.  See above for more details.