Remove comments from minified scripts.

jonathantneal / svg4everybody

Use external SVG spritemaps today

https://jonneal.dev/svg4everybody/

Other

3.29k stars 353 forks source link

Remove comments from minified scripts. #105

Closed gwer closed 8 years ago

gwer commented 8 years ago

It reduces files size almost twice.

prdolmos commented 8 years ago

This needs rebasing

shawnbot commented 8 years ago

Hey @gwer, I rebuilt this locally and pushed to this branch. Feel free to do the same on this branch and I can merge this PR; otherwise, I'll close this one and merge your commit via a new one.

shawnbot commented 8 years ago

Also, thank you! This is long overdue.

gwer commented 8 years ago

I'm sorry for your waiting. I did rebase and build new files for dist.

shawnbot commented 8 years ago

No problem, @gwer! When I said "this is long overdue," I was referring to the removal of comments from the minified builds; not your rebase. I'll get this merged and put out a new release soon! 🍻

shawnbot commented 8 years ago

Closing in favor of #123 because that one minifies even further by mangling variable names. Thank you for looking into this, @gwer!