search

jonathantneal / svg4everybody

Use external SVG spritemaps today
https://jonneal.dev/svg4everybody/
Other
3.29k stars 353 forks source link

Script becomes unresponsive in IE11 when USE is in MASK #134

Closed getsetbro closed 7 years ago

getsetbro commented 7 years ago

I attempted to put USE in a MASK and the script became unresponsive in IE11.

Simplified example: <svg> <defs> <mask id="mask"><use xlink:href="sprites.svg#text"></use></mask> </defs> <image xlink:href="img.jpg" mask="url(#mask)"/> </svg>

Edge loses the custom font. Here is a test repo page: http://getsetbro.github.io/maskingtext/

getsetbro commented 7 years ago

The svgxuse plugin by Keyamoon (of icomoon) does not fail at this: https://icomoon.io/svgxuse-demo/

timeiscoffee commented 7 years ago

Perhaps this is resolved by https://github.com/jonathantneal/svg4everybody/pull/117? Could you try with the script in the PR instead?

getsetbro commented 7 years ago

Yes that does fix it.

timeiscoffee commented 7 years ago

@getsetbro awesome! :)

timeiscoffee commented 7 years ago

@shawnbot please close this when https://github.com/jonathantneal/svg4everybody/pull/132 or https://github.com/jonathantneal/svg4everybody/pull/117 gets merged. Thanks!

getsetbro commented 7 years ago

When does this get merged?

timeiscoffee commented 7 years ago

@shawnbot @jonathantneal

chakzefir commented 7 years ago

@timeiscoffee any updates on this issue ?

timeiscoffee commented 7 years ago

@chakzefir unfortunately I don't have push access on this repo. I've reached out to @jonathantneal to grant me one, but had heard no replies :(

Someone else who has push access will have to resolve this. @shawnbot was the last active one, I believe.

jonathantneal commented 7 years ago

@timeiscoffee, you have been added, and if you send me your npm username, I can add you there as well for publishing.

timeiscoffee commented 7 years ago

Thanks @jonathantneal ! npm username is timeiscoffee.

jonathantneal commented 7 years ago

Wonderful. Added there as well. Did you happen to create that username recently?

timeiscoffee commented 7 years ago

@jonathantneal yes, just created it actually :)

jonathantneal commented 7 years ago

Thanks so much. That explains why I thought it hadn’t worked until you shared.

timeiscoffee commented 7 years ago

Thank you very much for the access!

timeiscoffee commented 7 years ago

v2.1.4 released and published to npm!

shawnbot commented 7 years ago

Thanks for dragging this over the finish line, @timeiscoffee! I haven't been able to offer much of my attention in the run up to the end of 2016 at work, and I'm glad y'all were able to pick up the slack.

andi1984 commented 6 years ago

@shawnbot @timeiscoffee I experience the same bug, but when there is a mask property on use (<use xlink="…" mask"…">). Can you please check?