search

jonathantorres / construct

A PHP project/micro-package generator for PDS compliant projects or micro-packages.
MIT License
266 stars 16 forks source link

Initial configuration feature implementation. Closes #86. #93

Closed raphaelstolt closed 8 years ago

raphaelstolt commented 8 years ago

Currently lacks the feature to overwrite single options provided to the ConstructCommand, which requires to modify variations directly in the .construct configuration file.

Also changed the option name from the proposed --configuration to --config. It's also possible to disable the usage of the default .construct configuration file via the --ignore-default-config option or its equivalent short option -i.

raphaelstolt commented 8 years ago

Rebased it against the latest master.

jonathantorres commented 8 years ago

I created a .construct file on my home directory with the following contents:

namespace: JonathanTorres
test-framework: phpspec
license: MIT

construct-with:
  - git
  - phpcs
  - editor-config
  - github-templates

I ran the command php construct generate jonathantorres/logger and got the following php warnings:

PHP Notice:  Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17

Notice: Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17
PHP Notice:  Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17

Notice: Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17
PHP Notice:  Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17

Notice: Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17
PHP Notice:  Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17

Notice: Undefined offset: 1 in /Users/jonathantorres/php/construct/src/Helpers/Travis.php on line 17

An composer threw the following exception:

[UnexpectedValueException]
  Could not parse version constraint >=: Invalid version string ""

Super weird. Let me know if you have any ideas.

Thanks so much for your work on this! :dancers:

raphaelstolt commented 8 years ago

The problem is that the PHP version is missing in the .construct file. I have pushed a fix where the systems PHP version is used when not present.

jonathantorres commented 8 years ago

All working as expected now. I'll merge this as a feature instead of bumping to 2.0 since is not breaking the default functionality. Thanks @raphaelstolt and @kayladnls for the code review! 👍