search

jonathanweiss / component-manager

Micro utility (583 bytes compressed) that manages initialising and teardown of components (e.g. jQuery plugins) as soon as specific DOM nodes are added into the document, respectively removed from it.
MIT License
7 stars 0 forks source link

An in-range update of uglify-js is breaking the build 🚨 #53

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 3.0.19 of uglify-js just got published.

Branch Build failing 🚨
Dependency uglify-js
Current Version 3.0.18
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As uglify-js is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/jonathanweiss/component-manager/builds/245554068?utm_source=github_status&utm_medium=notification)
Release Notes v3.0.19

 

Commits

The new version differs by 2 commits.

  • f67a6b0 v3.0.19
  • 343ea32 ensure mangling works if catch reuses a scope variable (#2123)

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 3.0.18 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 7 years ago

Version 3.0.20 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Release Notes v3.0.20

 

Commits

The new version differs by 9 commits.

  • 8b4dcd8 v3.0.20
  • 285401c more tests for #2158 (#2160)
  • 9db4c42 fix cascade & collapse on property access of constants (#2158)
  • 94e5e00 refactor compute_char_frequency() (#2152)
  • dc6bcaa synchronise mangle.properties for minify() & test/compress (#2151)
  • d58b184 refactor Compressor.toplevel (#2149)
  • b3a57ff minimise reduce_vars cloning overhead (#2148)
  • 3d5bc08 fix reduce_vars on this (#2145)
  • 0692435 fix for-in loop parsing (#2144)

See the full diff

jonathanweiss commented 7 years ago

Fixed with ff707dad6f72bc10c95d1b536f8a664adfcf287a