search

jonathanwin / yagv

A fast 3D Gcode Viewer for Reprap-style 3D printers, in Python and OpenGL
73 stars 48 forks source link

fix scrolling issue #12

Closed jmgurney closed 6 years ago

jmgurney commented 7 years ago

This branch includes the g0fix too.

On MacOSX I am getting lots of scroll events w/ 0 deltas, which the original code was zooming out on. Now we just skip the function is there isn't anything to do. Zoom out still works as -1 delta is kept.

jonathanwin commented 6 years ago

Hi @jmgurney , thanks for your PR. Could you explain what your commit 11c6728f56bc814c7a25ea79fdd02ba690b0b2af "this works around variable sub" supports? I accidentally merged it with the scroll fix.

jmgurney commented 6 years ago

Ahh, some gcode's use a type of variable substitution, so it doesn't always contain a number here. For example:

G1 Z15.0 F{travel_speed} ;move the platform down 15mm
G1 F{travel_speed}

This G-code was generated by:

;Generated with Cura_SteamEngine 2.3.1

and my 3d printer prints fine w/ this gcode.

jonathanwin commented 6 years ago

Ok, I see. Not sure if that's standard GCode (can't seem to find it in the NIST spec) but yagv clearly needs to support it (or at least not crash)

Thanks!

Jonathan

On 12 December 2017 at 02:57, John-Mark Gurney notifications@github.com wrote:

Ahh, some gcode's use a type of variable substitution, so it doesn't always contain a number here. For example:

G1 F{travel_speed}

This G-code was generated by:

and my 3d printer prints fine w/ this gcode.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jonathanwin/yagv/pull/12#issuecomment-350920124, or mute the thread https://github.com/notifications/unsubscribe-auth/ACqkGM3bJXSrCZtO0wUNdYyXnbqSp0U6ks5s_d2YgaJpZM4LkAS0 .