search

jonathanyeung / mark-sharp

Mark Sharp WYSIWYG Markdown Editor for VS Code
44 stars 0 forks source link

Newline in table cell is shown as <br> in wysiwyg mode #19

Open simoneggler opened 4 months ago

simoneggler commented 4 months ago

Describe the bug.

When creating a table with content that has newlines, it will be rendered as '
' when switching back to source view and reopening the mark sharp editor.

Repro Steps

  1. create a table image

(add newline with shift-enter)

  1. switch to source view, table is correctly created as: 
| h1           | h2                         |
| ------------ | -------------------------- |
| Some Content | Other Content<br/>New Line |
| Ohat         |                            |
  1. reopen the mark sharp editor, table renders the newline as follows
image

Version

2.142

What platform are you seeing the problem on?

vscode.dev (web)

jonathanyeung commented 4 months ago

Hi @simoneggler - thanks for filing this; I can repro. I'll add it to my backlog.

jonathanyeung commented 3 months ago

This should be fixed in 1.4.0, which was just released. Let me know if you're still seeing issues, thanks!

simoneggler commented 3 months ago

Thanks, the
have gone...

There's still a small issue. When starting editing the table in wysiwyg mode, bullets are rendered. When you close and reopen the wysiwyg editor, the bullets are no longer rendered.

i believe that no rendering the bullets is more correct, because cell-inline styling is not supported by markdown.

image