search

jonathanyeung / mark-sharp

Mark Sharp WYSIWYG Markdown Editor for VS Code
44 stars 0 forks source link

VSCode theme is not respected #7

Open dnabb opened 6 months ago

dnabb commented 6 months ago

Describe the bug Mark Sharp does not seem to respect the active VSCode theme and shows up with a white background.

To Reproduce Set VSCode to any dark theme and then switch to MarkSharp. I am using the Markdown Theme Kit - Visual Studio Marketplace, but the issue seems to happen with any theme, at least for me.

Expected behavior VSCode theme should be followed as closely as possible

Screenshots 20240523161536_Code_2024-05-23_-_155641 md_-_RandomNotes_(Workspace)_-

Platform (please complete the following information):

jonathanyeung commented 6 months ago

Hi @dnabb - thanks for the feedback! Full VS Code theming is limited to the premium version of Mark Sharp (please see the licensing page); the basic version defaults to the light theme. For a full list of features that come with Mark Sharp Premium, you can view the page shown from running the command Mark Sharp: Manage License.

I apologize for the confusion - I have an outstanding item to surface this information in a better way.

jonathanyeung commented 2 months ago

With version 1.5.0, the free version of Mark Sharp now includes a default dark theme. To get full matching with your VS Code, please see Mark Sharp Premium. Thank you!

jswhisperer commented 1 month ago

Sorry to be the opposite of above but would it be possible to have the white background. I like a dark theme for coding, but white like "medium" for writing. I understand custom themes is part of the premium package but maybe just default light/dark could be available in vscode? Thanks for the plugin.