jonbarron / robust_loss_pytorch

A pytorch port of google-research/google-research/robust_loss/
Apache License 2.0
656 stars 88 forks source link

Refactored project as installable package #8

Closed khornlund closed 5 years ago

khornlund commented 5 years ago

Re: #6

Summary of changes:

Notes:

Cheers, Karl

jonbarron commented 5 years ago

Very nice work! Thanks for doing this. I also couldn't figure out how to skip CUDA tests, and just got used to the idea of them failing when there's no GPU available, which isn't perfect but doesn't seem too bad.

I agree that more detailed examples are needed. I can make a "hello world" regression demo script, though I've never written a pytorch optimization loop so it may be a bit weird. That should resolve some of the confusion in the other thread about how to include parameters.